Tic Tac Toe... in React Mode #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't like the spread operator on line 29. Keeping the code as is.
reneemeyer
reviewed
Sep 5, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Craig, nice job, just a couple questions. I would be extremely careful about storing values outside of the state. It is possible, but it should only be used in edge cases, the reason being, your react components will update on state or prop change they won't necessarily on a property change. We can go over some ideas about how you would avoid this.
| state[cell] = this.state.turn; | ||
| // console.log('value of checkForWin', this.checkForWin(state)); | ||
| if (this.checkForWin(state)) { //checkForWin returns TRUE if someone won. It returns FALSE if no win yet. | ||
| this.message = `Congratulations ${this.state.turn}. You won! Start a new game by refreshing`; |
There was a problem hiding this comment.
Why are you storing message in a class global instead of the state?
| this.state = { | ||
| turn: 'X', | ||
| }; | ||
| this.initialState = { |
There was a problem hiding this comment.
This doesn't seem to be used anywhere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tic Tac Toe... take 3