Skip to content

Conversation

@MrXANA91
Copy link
Contributor

@MrXANA91 MrXANA91 commented Dec 11, 2025

As there is currently no way to change this setting for the moment, this PR adds a Distance Unit setting toggler linked to the already existing Units Distance preference, inside a new Health menu.

We can now easily toggle between Kilometers and Miles.

@MrXANA91 MrXANA91 force-pushed the settingsUnitsDistance branch from b8f12d2 to 59593d3 Compare December 11, 2025 10:51
@MrXANA91 MrXANA91 marked this pull request as ready for review December 11, 2025 11:01
Setting toggler linked to already existing Units Distance pref

Signed-off-by: Paul Chanvin <paul@paulchanvin.fr>
@MrXANA91 MrXANA91 force-pushed the settingsUnitsDistance branch from 59593d3 to 43a8e56 Compare December 11, 2025 11:02
@gmarull
Copy link
Member

gmarull commented Dec 11, 2025

coredevices/mobileapp#54

@MrXANA91
Copy link
Contributor Author

It might be relevant to have this setting both on the mobileapp and on the watch.

Or, at least, having access to this setting on the watch while the mobileapp health integration is being built.

@gmarull gmarull requested review from ericmigi and jplexer December 11, 2025 14:50
Copy link
Member

@jplexer jplexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise this is fine, but I dont necessarily agree this should be a watch setting. Waiting for @ericmigi to say something

Copy link
Collaborator

@ericmigi ericmigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move this to the phone side when we have Health fully integrated. Thanks for your contribution!

@jplexer jplexer merged commit 2c73c46 into coredevices:main Dec 11, 2025
20 checks passed
@MrXANA91 MrXANA91 deleted the settingsUnitsDistance branch December 12, 2025 12:15
@MrXANA91 MrXANA91 mentioned this pull request Jan 13, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants