notifications: support iOS custom icon/vibe/color #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
reviewed
Jan 13, 2026
| if (notif_prefs) { | ||
| uint32_t pref_icon = attribute_get_uint32(¬if_prefs->attr_list, AttributeIdIcon, 0); | ||
| if (pref_icon != 0) { | ||
| if (pref_icon < 512) { |
Member
There was a problem hiding this comment.
please avoid hardcoding magic numbers ;-)
jplexer
approved these changes
Jan 13, 2026
Member
jplexer
left a comment
jplexer
left a comment
There was a problem hiding this comment.
other than the magic number (that gerard pointed out) this looks good to me!
asyba
force-pushed
the
ios-support-vibe-icon-color
branch
from
915910c to
572a60a
Compare
gmarull
reviewed
Jan 15, 2026
|
|
||
| //! Maximum resource ID value that is considered a system resource. | ||
| //! Resource IDs below this threshold need SYSTEM_RESOURCE_FLAG set. | ||
| #define MAX_SYSTEM_RESOURCE_ID 512 |
Member
There was a problem hiding this comment.
how is that related to e.g.
#define MAX_RESOURCES_PER_STORE 256
#define MAX_RESOURCES_FOR_SYSTEM_STORE 768
?
Contributor
Author
There was a problem hiding this comment.
done added import from resource_storage_impl
Signed-off-by: Federico Bechini <federico.bechini@gmail.com>
asyba
force-pushed
the
ios-support-vibe-icon-color
branch
from
572a60a to
9fa8568
Compare
gmarull
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS support for custom icon/vibe/color notifications.
The custom vibe pattern is not supported for the moment, it requires more work on the mobileapp side. FW should be fine.
PR mobileapp: coredevices/mobileapp#99
Tested on iOS only with Duo2.