Skip to content

Use coredns/caddy to fix tests#3

Open
pvsune wants to merge 6 commits intocoredns:masterfrom
pvsune:master
Open

Use coredns/caddy to fix tests#3
pvsune wants to merge 6 commits intocoredns:masterfrom
pvsune:master

Conversation

@pvsune
Copy link

@pvsune pvsune commented Nov 5, 2021

The tests fail:

$ go test ./...
# github.com/coredns/records [github.com/coredns/records.test]
./records_test.go:24:25: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to recordsParse
./records_test.go:83:25: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to recordsParse
./records_test.go:136:25: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to recordsParse
FAIL    github.com/coredns/records [build failed]
FAIL

Looks like there is inconsistency in using caddy in recordsParse(), use the stripped down coredns/caddy instead.

Signed-off-by: Philamer Sune <philamer.sune@agoda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant