This repository was archived by the owner on Sep 18, 2020. It is now read-only.
scripts: add more options in qemu script#733
Open
cristiklein wants to merge 1 commit intocoreos:masterfrom
Open
scripts: add more options in qemu script#733cristiklein wants to merge 1 commit intocoreos:masterfrom
cristiklein wants to merge 1 commit intocoreos:masterfrom
Conversation
I frequently need to change the number of processors, memory and VM name. This change allows the user to specify these options when booting CoreOS from the qemu script.
Contributor
|
Trailing arguments are supported and added to the qemu invocation. Using something like: $ ./coreos_production_qemu.sh -name asdf -smp cpus=10will change the name, number of processors, etc. I'm not sure we need this mechanism as well since it doesn't hide a significant amount of abstraction (as opposed to the |
Author
|
I see your point. There is, however, a minor downside to the solution you proposed, in that the command-line of qemu (e.g., Would you be more open to an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts: add more options in qemu script
I frequently need to change the number of processors, memory and VM name. This change allows the user to specify these options when booting CoreOS from the qemu script.