This repository was archived by the owner on Sep 22, 2020. It is now read-only.
torusd: add peer-address to http scheme by default#325
Open
nak3 wants to merge 1 commit intocoreos:masterfrom
nak3:addrtouri
Open
torusd: add peer-address to http scheme by default#325nak3 wants to merge 1 commit intocoreos:masterfrom nak3:addrtouri
nak3 wants to merge 1 commit intocoreos:masterfrom
nak3:addrtouri
Conversation
Contributor
Author
|
Or should I use this function to add default scheme? |
Contributor
|
Yeah, the intent was to add default scheme |
nak3
changed the title
Contributor
Author
|
Alright. I updated. |
xiang90
reviewed
Dec 13, 2016
| } | ||
| } | ||
|
|
||
| func addrToUri(addr string) (*url.URL, error) { |
Contributor
There was a problem hiding this comment.
not a fan of moving util code to cmd main.go. but we do not have any internal util pkg now.
opinions? @barakmich @lpabon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.