This repository was archived by the owner on Sep 22, 2020. It is now read-only.
clean up errors in torusd#329
Open
nak3 wants to merge 5 commits intocoreos:masterfrom
nak3:torusd-error
Open
Conversation
mischief
suggested changes
Sep 22, 2016
cmd/torusd/main.go
Outdated
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "couldn't get ring: %v\n", err) | ||
| return err | ||
| return errors.New(fmt.Sprintf("couldn't get ring: %v", err)) |
cmd/torusd/main.go
Outdated
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "couldn't add peer to ring: %v", err) | ||
| return err | ||
| return errors.New(fmt.Sprintf("couldn't add peer to ring: %v", err)) |
Contributor
Author
|
Thank you. I updated. |
xiang90
reviewed
Dec 13, 2016
cmd/torusd/main.go
Outdated
| } else { | ||
| fmt.Printf("Couldn't debug-init: %s\n", err) | ||
| os.Exit(1) | ||
| return fmt.Errorf("Couldn't debug-init: %s", err) |
Contributor
There was a problem hiding this comment.
could't ...
error msg should not start with capitalized letter.
Contributor
Author
|
Thank you. I updated them and other messages as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.