This repository was archived by the owner on Sep 22, 2020. It is now read-only.
tcmu: call close when OpenTCMUDevice returns error#417
Open
nak3 wants to merge 1 commit intocoreos:masterfrom
nak3:tcmu-close
Open
tcmu: call close when OpenTCMUDevice returns error#417nak3 wants to merge 1 commit intocoreos:masterfrom nak3:tcmu-close
nak3 wants to merge 1 commit intocoreos:masterfrom
nak3:tcmu-close
Conversation
Contributor
Author
|
Why is this patch needed? What is it resolving? Normally you do not want to close something which was not created. Some functions return |
Contributor
Author
|
This fix needs to wait for go-tcmu's fix https://github.com/coreos/go-tcmu/pull/8/files (I commented it above.). And it will never return The reason why this patch needed is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.