[Bugfix][IR][AIE] using cpp-style implicit type casting rule for aie backend#485
Conversation
|
Compatibility issue 1: become invalid after llvm version update. During construction, it now raises the following error: ValueError: Cannot overwrite type mapping T = i32 by type i16.According to
|
…e to match the element type of the output.
|
Compatibility issue 2: mlir object equality check seems different. e.g., |
In this case we should use |
right |
chhzh123
left a comment
There was a problem hiding this comment.
LGTM. Let me know when it is ready to merge.
| global_vars: dict = None, | ||
| instantiate: list = None, | ||
| context: Context = None, | ||
| typing_rule_set="default", | ||
| unroll: bool = True, | ||
| ) -> Schedule: |
There was a problem hiding this comment.
Could you also help add a docstring to document what the arguments mean in this customize function?
|
ready to merge |
|
Is this PR a replacement of #462? Can I close that one? |
|
partially. It only addresses type casting issues for aie backend. Some redundant type casting in the hls backend is not handled here. I think #462 can be closed. If we do want to clean up some redundant type casting in our IR, #462 is not an elegant solution, we should consider alternative approaches. |
|
Let's keep #462 open then |
Description
Problems
Proposed Solutions
aiebackend.Checklist
Please make sure to review and check all of these items: