Improve the Profile.py $rawprofile Command#156
Open
Calebh101 wants to merge 3 commits intocorpnewt:rewritefrom
Open
Improve the Profile.py $rawprofile Command#156Calebh101 wants to merge 3 commits intocorpnewt:rewritefrom
Calebh101 wants to merge 3 commits intocorpnewt:rewritefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
discord.utils.escape_markdown(item['URL'])alone, which doesn't properly escape things like titles, subtitles, and many more - as seen in this example:I've changed the message logic to use a new function that properly escapes certain effects and prefixes:
This will format profiles like the following:
This makes it a lot easier to edit heavily-formatted profiles, or transfer profiles across servers, as previously, you would have to use
Copy Textand edit out the top line (likeCaleb's codeblock Profile:).Note:
_format_codeblockis included for the ability to format as a markdown code block, but it doesn't work with nested code blocks.I have tested this with my own bot instance, but let me know if you find other issues while the PR is still pending and I can work on it!