Closed
Conversation
Collaborator
|
Thank you so much, @PbU-Jason! Indeed, I agree with you, we need to be a little more careful with the main branch now that we're starting to make releases. I'll work on this. In the meantime, I'll mark this PR as a draft to prevent an accidental merge. |
Collaborator
|
Tagging @Yong2Sheng. Hopefully this could be merged with the current code. |
Contributor
|
Thank you very much @PbU-Jason and @israelmcmc, I will also take a look at this. |
Collaborator
|
I changed the target branch to "develop". I want to avoid adding new features to the version we're releasing today. I'll explain this further tomorrow during the cosipy meeting. |
Collaborator
|
I'm closing this in favor of #248, since it's based on the same code. Thank you, @PbU-Jason! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm Jason.
I reviewed my previous code on implementing multi-resolution TS map using HealpixMap.
My notebook and explanatory PDF file have been put to cosipy/cosipy/ts_map/preliminary/.
I was hoping that my pull request would not affect the main branch. However, I can not create a branch on cositools/cosipy/.
Therefore, I'm pulling my local branch directly to the main branch of cositools/cosipy/.
Please let me know if anything is wrong. Thanks a lot!