No magic cells in automatic run_tutorial.py and other related changes#349
Open
israelmcmc wants to merge 7 commits intocositools:developfrom
Open
No magic cells in automatic run_tutorial.py and other related changes#349israelmcmc wants to merge 7 commits intocositools:developfrom
israelmcmc wants to merge 7 commits intocositools:developfrom
Conversation
…fore failing tutorials were showing as passing. Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…ean log file handler Signed-off-by: Israel Martinez <imc@umd.edu>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized, by eye and by chance, that one of the cells of the TS map tutorial was failing. Interestingly, the notebook continued running until the end, and the program reported a success.
While the error was only in a file checksum (fixed by this PR), and the code and tutorial are fine, this prompted me to look why this was not reported as an error.
As it happens, "cell magics" (the ones with "%%" at the beginning of the cell) are run in sub-process, and therefore the errors are caught inside and supressed. In particular, the TS map notebook is using the "%%capture" magic. Other notebooks use the "%%time" magic as well.
Prompted by this I changed a few things: