Transient background estimation#460
Open
Yong2Sheng wants to merge 4 commits intocositools:developfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
…ator; add unit test for TransientBackgroundEstimation 100% coverage!
Contributor
Author
|
The new changes are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of estimating the background for transients. It averages the background windows on the two sides of the burst and scale it to the burst window.
Now it only supports scaling by burst duration. We can also fit the burst background level in a light curve using the background windows first. Then, use the fitted result to estimate the number of background counts in the burst interval. This scaling method can be supported after merging #239