Adding Strip Pairing Quality Flags#90
Open
julianmgerber wants to merge 4 commits intocositools:develop/emfrom
Open
Adding Strip Pairing Quality Flags#90julianmgerber wants to merge 4 commits intocositools:develop/emfrom
julianmgerber wants to merge 4 commits intocositools:develop/emfrom
Conversation
Collaborator
|
That one conflicts with @ckierans changes - let Carolyn do her changes first and then update. Then i will review |
Collaborator
|
@julianmgerber the other PR handling QA and BD flags was merged, so you should be able to make progress on this one now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing quality flags for the strip pairing module instead of just filtering out events.
Thresholds/filters that are now a quality flag:
Points 1-4 are all included in the new StripPairingQualityFlag variable and each have their own warning message attached to them. The flags for multiple hits on a single strip however are defined on the MHit level (as opposed to the event level) and are not included in the StripPairingQualityFlag category.