Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attitude.shape() returns a tuple that is either empty for a single rotation or a singleton with the length of the rotation stack for vectorized rotation. This method was improved in the current develop branch to extract this shape more efficiently using as_quat(), but there is in fact no reason to force a representation change to get the information.
This patch directly interrogates the length of the rotation stack to compute the shape, handling the special case of a single rotation for which len() is not defined. On a large (len() on the order of hundreds of thousands) Attitude, this change reduced the cost of shape from around 0.6s to negligible on my machine.