feat: redesign bank precompile for erc20 support #804
Conversation
Closes: cosmos#505 Supersedes: cosmos#517 Use go-abi to simplify implementation. update erc20 source
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for k, v := range generator.ParseExternalTuples(*extTuplesFlag) { | ||
| extTuples[k] = v | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for denom, amount := range m { | ||
| coin := sdk.NewCoin(denom, sdkmath.NewInt(amount)) | ||
| if cb(coin) { | ||
| break | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for denom, amount := range k.supplies { | ||
| coin := sdk.NewCoin(denom, sdkmath.NewInt(amount)) | ||
| if cb(coin) { | ||
| break | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 65.43% 65.64% +0.20%
==========================================
Files 318 323 +5
Lines 22244 22492 +248
==========================================
+ Hits 14556 14765 +209
- Misses 6521 6536 +15
- Partials 1167 1191 +24
🚀 New features to boost your workflow:
|
|
looks like we might need a |
|
Anything we need to do to get our code coverage up? |
I removed generated abi files from the coverage, the report looks good now. |
| Precompile: cmn.Precompile{ | ||
| KvGasConfig: storetypes.GasConfig{}, | ||
| TransientKVGasConfig: storetypes.GasConfig{}, | ||
| ContractAddress: common.HexToAddress(evmtypes.BankPrecompileAddress), |
There was a problem hiding this comment.
It looks need to set BalanceHandlerFactory
There was a problem hiding this comment.
Currently, it explicitly reject to handle native token in transferFrom method.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
mmsqe
force-pushed
the
bank-precompile2
branch
from
99809d3 to
4d6b580
Compare
5 participants
Description
Closes: #505
Supersedes: #517
Use go-abi to simplify implementation, see: #789
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch