Enable SwiftUI environment-based store injection for @AppSetting #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
- Modified __Settings_Container protocol to use 'any UserDefaultsStore' instead of associated type
- Changed observer return type from associated type to 'any Cancellable'
- Updated AppSettingValues to use OSAllocatedUnfairLock for thread-safe store access
- Added support for mock stores in SwiftUI previews via environment injection
- Updated all test containers to match new protocol requirements
BREAKING CHANGE: Custom __Settings_Container implementations must now declare:
static var store: any UserDefaultsStore { get }
instead of using an associated type.
This enables dynamic store switching for testing and previews without requiring
actor isolation, maintaining flexibility while ensuring thread-safety.
couchdeveloper
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
BREAKING CHANGE: Custom __Settings_Container implementations must now declare:
static var store: any UserDefaultsStore { get }
instead of using an associated type.
This enables dynamic store switching for testing and previews without requiring actor isolation, maintaining flexibility while ensuring thread-safety.