Improve observer lifecycle and KVO compliance #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure prefix property is KVO compliant by replacing dots with underscores - Fix observer lifecycle: cancel and recreate subscription when store changes - Add AnyObject constraint to UserDefaultsStore protocol for identity comparison - Refactor UserDefaultsStoreMock: make helper methods static
couchdeveloper
added
the
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1. KVO-Compliant Prefix Validation
File:
AppSetting.swiftAppSettingValues.prefixsetterBreaking
Additional Detail
The observer lifecycle fix addresses a critical issue where SwiftUI views would continue observing old store instances after switching to mock stores in previews. The KVO compliance ensures prefix strings work correctly with Foundation's observation mechanism.