CLUSTER_ID is required for Redshift shell to work.#256
Open
eldhosejohn wants to merge 1 commit intocoursera:developfrom
Open
CLUSTER_ID is required for Redshift shell to work.#256eldhosejohn wants to merge 1 commit intocoursera:developfrom
eldhosejohn wants to merge 1 commit intocoursera:developfrom
Conversation
…connection string.
Contributor
Author
|
This commit is connected with the following PR - #255. Here CLUSTER_ID is not considered (skipped) when CONNECTION_STRING is in use (i.e when connecting to Redshift hosted outside VPC). However CLUSTER_Id is required for the redshift shell (psql command) to work. I am currently using dataduct in production. @sb2nov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently selecting either CONNECTION_STRING or CLUSTER_ID. This will cause error when try to run redshift shell ('dataduct sql_shell redshift') using jdbc connection string, as this requires CLUSTER_ID. Modified the code to pick the CONNECTION_STRING if both fields are available. This will make the sql shell to work.