lab: externalize legacy components

[louis-bompart]

No description provided.

[Copilot]

Pull request overview

This pull request externalizes legacy Stencil components from the main @coveo/atomic package into a new @coveo/atomic-legacy package as part of the ongoing migration from Stencil to Lit. Currently, only the atomic-suggestion-renderer component has been moved to this new legacy package.

Key Changes:

• Created new @coveo/atomic-legacy package with Stencil build configuration
• Moved atomic-suggestion-renderer component from packages/atomic/src/components/common/ to packages/atomic-legacy/src/
• Updated imports in search box components to reference the legacy package

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pnpm-workspace.yaml	Added packages/atomic-legacy to workspace packages
pnpm-lock.yaml	Updated lock file with atomic-legacy dependencies and workspace links
packages/atomic-legacy/package.json	Created package.json for legacy package with dependencies and build script
packages/atomic-legacy/tsconfig.json	Created TypeScript configuration for Stencil compilation
packages/atomic-legacy/stencil.config.ts	Created Stencil build configuration with dist-custom-elements output
packages/atomic-legacy/.gitignore	Added gitignore to exclude Stencil build artifacts
packages/atomic-legacy/src/atomic-suggestion-renderer.tsx	Moved component implementation with inline type definitions to avoid external dependencies
packages/atomic/package.json	Added @coveo/atomic-legacy as workspace dependency
packages/atomic/src/components/search/atomic-search-box/atomic-search-box.ts	Updated import to use legacy package
packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts	Updated import to use legacy package
packages/atomic/src/components/insight/atomic-insight-search-box/atomic-insight-search-box.tsx	Updated import to use legacy package
packages/atomic/src/components/common/atomic-suggestion-renderer/atomic-suggestion-renderer.spec.tsx	Deleted test file (component moved to legacy package)
biome.jsonc	Excluded atomic-legacy tsx files from Biome linting during migration

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The private field should be a boolean value, not a string. Change "true" to true (without quotes).

Suggested change

	"private": "true",
	"private": true,

[Copilot]

The package exports reference ./dist/types/index.d.ts and ./dist/index.js, but the Stencil configuration only outputs dist-custom-elements which creates a dist/components/ directory. Either the exports should be updated to match the actual build output paths, or the Stencil configuration needs to include additional output targets (such as dist type) to generate the expected files.

[Copilot]

The atomic-legacy package should include a README.md file explaining its purpose as a temporary home for legacy Stencil components during the migration to Lit, and providing basic usage documentation for consumers.