Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 8, 2026

no story, mdx or e2e as it is an internal component

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-5358

Copilot AI and others added 2 commits January 8, 2026 17:10
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Co-authored-by: alexprudhomme <78121423+alexprudhomme@users.noreply.github.com>
Copilot AI changed the title [WIP] Migrate atomic-recs-result to Lit feat(atomic): migrate atomic-recs-result to Lit Jan 8, 2026
Copilot AI requested a review from alexprudhomme January 8, 2026 17:21
@alexprudhomme alexprudhomme changed the title feat(atomic): migrate atomic-recs-result to Lit chore(atomic): migrate atomic-recs-result to Lit Jan 8, 2026
@alexprudhomme alexprudhomme force-pushed the copilot/migrate-to-lit branch from 73180a4 to 2487a26 Compare January 8, 2026 18:38
@alexprudhomme alexprudhomme marked this pull request as ready for review January 8, 2026 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the atomic-recs-result component from Stencil to Lit as part of the ongoing framework migration effort. The component is used internally by atomic-recs-list to render individual recommendation results with customizable layouts, density settings, and template content.

Key changes:

  • Migrated from Stencil .tsx to Lit .ts implementation with proper decorators and reactive controllers
  • Replaced Stencil lifecycle hooks with Lit equivalents (connectedCallback, disconnectedCallback, firstUpdated)
  • Introduced ItemLayoutController and CustomRenderController for managing layout and custom rendering
  • Added comprehensive unit test coverage (572 lines) including edge cases for undefined content and custom rendering functions
  • Updated type definitions and React wrapper integration

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/atomic/src/components/recommendations/atomic-recs-result/atomic-recs-result.tsx Removed legacy Stencil implementation
packages/atomic/src/components/recommendations/atomic-recs-result/atomic-recs-result.ts New Lit implementation with reactive controllers and proper lifecycle management
packages/atomic/src/components/recommendations/atomic-recs-result/atomic-recs-result.spec.ts Comprehensive unit tests covering props validation, event handlers, rendering modes, and edge cases
packages/atomic/src/components/recommendations/atomic-recs-result/atomic-recs-result.pcss Removed PostCSS file (styles now inline)
packages/atomic/src/components/recommendations/index.ts Added export for new Lit component
packages/atomic/src/components/recommendations/lazy-index.ts Added lazy loading entry for new Lit component
packages/atomic/src/utils/custom-element-tags.ts Registered component tag
packages/atomic/src/components.d.ts Removed auto-generated Stencil type definitions
packages/atomic-react/src/components/search/components.ts Added React wrapper for new Lit component
packages/atomic-react/src/components/search/ResultListWrapper.tsx Updated type references to use component types instead of exported constants
packages/atomic-react/src/components/commerce/CommerceProductListWrapper.tsx Updated type references to use component types instead of exported constants
packages/atomic/src/components/recommendations/atomic-recs-result-template/atomic-recs-result-template.ts Added import for new Lit component
packages/atomic/src/components/common/item-list/display-wrapper.ts Updated import path for ItemDisplayLayout type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ult/atomic-recs-result.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ult/atomic-recs-result.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants