separate guest import and export code#25
Open
PradeepKiruvale wants to merge 8 commits intocpetig:mainfrom
Open
separate guest import and export code#25PradeepKiruvale wants to merge 8 commits intocpetig:mainfrom
PradeepKiruvale wants to merge 8 commits intocpetig:mainfrom
Conversation
added 4 commits
May 23, 2024 10:32
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
PradeepKiruvale
force-pushed
the
refactor-native-string
branch
from
5acd4c8 to
eb016b7
Compare
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
cpetig
reviewed
Jun 3, 2024
| __attribute__((import_name("c"))) void | ||
| cabi_post_fooX3AfooX2FstringsX23c(uint8_t *); | ||
| extern "C" void fooX3AfooX2FstringsX00a(uint8_t *arg0, size_t arg1) { | ||
| extern "C" void fooX3AfooX2FstringsX00a(uint8_t *arg0, size_t arg1) { |
cpetig
reviewed
Jun 3, 2024
| clean: | ||
| -rm *.o libstrings.so app-strings | ||
|
|
||
| run: |
Owner
There was a problem hiding this comment.
I fear these targets don't make much sense for the guest directory
cpetig
reviewed
Jun 3, 2024
|
|
||
| ``` | ||
|
|
||
| # Call-graph for a function |
added 3 commits
June 5, 2024 18:06
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
Signed-off-by: Pradeep Kumar K J <pradeep.kumar.kj@aptiv.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have separated the guest import and export calls into separate files in this PR.
I also did some code formatting
Restructured the code as below
The directory strucutre is as below:
├── cpp_host (Native host code)
├── guest (Guest code)
├── guest_imported_fns.cpp ( host application imported calls)
├── main.cpp (Application)
└── wit (Wit file that is used for generating the code)
Added a native string rust code