Fix: Add productos table for Exercise #28#3
Merged
camilocbarrera merged 9 commits intomainfrom Jan 4, 2026
Merged
Conversation
- Add productos table with id, nombre, precio, categoria columns - Add producto_id foreign key to pedidos table - Insert 8 sample products across categories - Update pedidos records with producto_id references Fixes #2
- Install vitest dependency - Add test and test:watch npm scripts - Configure vitest with node environment and path aliases
- Add db-schema.ts with table/column definitions - Add sample-solutions.ts with 50 SQL solutions for all exercises
- Add schema consistency tests (71 tests) - Add solution execution tests (56 tests) - Validate table/column references exist in DB schema - Verify sample solutions execute successfully against PGlite
- Run lint, test, and build on PRs and pushes to main - Use Bun for fast dependency installation - Block merging if any step fails
- Convert single quotes to double quotes - Add semicolons to statements - Organize imports alphabetically - Apply consistent formatting across all files
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Use node: protocol for fs and path imports - Replace non-null assertion with nullish coalescing - Add type='button' to prevent form submission - Use unique keys instead of array indices
- Remove unused imports - Fix async Promise executor pattern - Update biome config for project-specific rules - Add type='button' to prevent form submission - Exclude CSS files from biome (Tailwind syntax)
- Build requires valid Clerk keys and database connection - Vercel deployment already handles production builds - CI now focuses on lint and test for code quality
frankyemm
approved these changes
Jan 4, 2026
frankyemm
left a comment
frankyemm
left a comment
There was a problem hiding this comment.
I see 78-84 you create the product tables, 88 you add the fk in pedidos and 109-118 you insert products mockup, nice job
Member
Author
|
Merged! thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2 - Exercise #28 "Múltiples JOINs" was failing because the
productostable didn't exist.Changes
Bug Fix
productostable with columns:id,nombre,precio,categoriaproducto_idforeign key topedidostableTesting Infrastructure
CI/CD
Test Results
cc @frankyemm