fix: Improve Monaco Editor keyboard shortcuts and autocomplete widget display#5
Merged
camilocbarrera merged 2 commits intocrafter-station:mainfrom Jan 13, 2026
Merged
Conversation
- Increase z-index for suggestions widget to ensure it appears above other elements - Adjust overflow settings for Monaco Editor container to prevent clipping of suggestions - Enable additional suggestion features in SQL editor configuration
- Implement Ctrl+Enter and Ctrl+Shift+F commands for executing SQL and formatting code, respectively. - Refactor key handling to use refs for onExecute and formatSQL functions, improving performance and readability.
|
@EdwardR0507 is attempting to deploy a commit to the camilocbarrera's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fixes
Fixed Ctrl+Enter keyboard shortcut
Ctrl+Enter(orCmd+Enteron Mac) was not executing queries when the editor had focuswindowevent listener with Monaco Editor's nativeeditor.addCommand()APIKeyMod.CtrlCmdFixed autocomplete widget visibility
Ctrl+Spacez-index: 10000)overflow-hiddentooverflow-visibleto prevent clipping✨ Improvements
Enhanced Monaco Editor suggestions configuration
showIcons,showStatusBar, andshowSnippetsoptions for better UXacceptSuggestionOnCommitCharacterandacceptSuggestionOnEnterfor smoother autocomplete interactionsnippetSuggestions: "top"to prioritize code snippets🔧 Technical Details
onExecuteRef,formatSQLRef) to avoid closure issues with Monaco commandsuseEffecthooks following React best practices✅ Testing
Ctrl+Enterexecutes queries when editor has focusCtrl+Shift+Fformats SQL correctlyCtrl+SpaceKeyMod.CtrlCmd)