Conversation
crbelaus
reviewed
Sep 13, 2025
Owner
crbelaus
left a comment
crbelaus
left a comment
There was a problem hiding this comment.
I wonder if we shouldn't use stdin: "inherit" instead like we do for stdout and for stderr. Can you test if it works properly with Vite?
Contributor
Author
|
It's been a few weeks, but iirc inherit meant the wrapper didn't handle exits properly anymore. There's not really data sent down anyways, so it shouldn't really matter. |
crbelaus
approved these changes
Sep 14, 2025
Owner
|
Makes sense. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't extensively tested this, but it seems to work for my usecase.
The problem was that I made vite handle stdin closing by itself (for nodejs) and then the wrapper would make the process close immediately. This should work no matter if the started process handles stdin closes by itself.