Officially unsupport multi-line attribute blocks. #95
Open
AnalyzePlatypus wants to merge 2 commits intocreationix:masterfrom
Open
Officially unsupport multi-line attribute blocks. #95AnalyzePlatypus wants to merge 2 commits intocreationix:masterfrom
AnalyzePlatypus wants to merge 2 commits intocreationix:masterfrom
Conversation
HAML-js does not support multi-line attribute blocks. The error message now correctly notes this.
|
I think that clears things up nicely. Spreading different attributes across multiple lines is handy for readability, but certainly not required. As long as users know they're not crazy, they need to adjust their markup. |
|
Having lines of 500chars because this library does not support multi-lines is not what I call readability, it's common sense. Has anyone ever wrote a function in js as a single line of 500chars? nonsense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.
HAML-js does not support multiline attribute blocks.
This PR clarifies this fact in several places.
Malformed attribute blocknow readsMulti-line attribute blocks are unsupported in HAML-jsDifferences from Ruby HAMLto theReadme, and notes that: