Draft
Conversation
Lifts the usage of `raw(f)` one level higher into the RawMode effect trait and creates a method on the lower level terminals that enters raw mode and returns a thunk to exit raw mode.
Lift application and alternateScreen modes into higher level API, leaving low level terminal to have a set and rollback.
kapunga
force-pushed
the
refactor-terminal-modes
branch
from
254c375 to
4221fc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move function bracketing from the lower level terminal implementations to the higher level traits. Lower level terminal implementations now return a rollback thunk:
() => Unitto be called generically to perform a rollback. I made the lower level terminal methods package private as you have to be careful to call the rollback in afinallyblock.Resolves #27