Addition of 'void' Return Type Declaration in AbstractSpatialDQLFunction#223
Open
enzobrigati wants to merge 29 commits intocreof:developfrom
Open
Addition of 'void' Return Type Declaration in AbstractSpatialDQLFunction#223enzobrigati wants to merge 29 commits intocreof:developfrom
enzobrigati wants to merge 29 commits intocreof:developfrom
Conversation
Update install.md
Fix PostgreSql function class names
Update configuration.md
Added support for geometry function
Added support for ST_Collect function
Improved getting the sql for functions
Support PHP 7.1
Added ST_SnapToGrid support
Implemented ST_Overlaps
…rrayOfPoints Added test for polygon from array of points
Change Tabs to Spaces.
Fix indent.
Create STGeomFromText
* Added ST_Distance_Sphere to mysql * Added ST_Distance_Test to mysql * Updated travis ci config * Updated a test case * Fixed a typo * Updated INSTALL.md * Added STGeographyFromText to test case * Added STGeographyFromText class * Added STGeomFromText * Fixed some tests * Update phpunit.xml.dist
…ction' In line with upcoming changes in Doctrine, the 'parse()' method in 'Doctrine\ORM\Query\AST\Functions\FunctionNode' may require a native 'void' return type declaration. This patch adds this declaration to the child class 'CrEOF\Spatial\ORM\Query\AST\Functions\AbstractSpatialDQLFunction' to prevent potential errors. An explicit '@return void' annotation is also included to suppress warnings related to this deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Doctrine is planning to introduce a native 'void' return type declaration for the 'parse()' method in
Doctrine\ORM\Query\AST\Functions\FunctionNode. This future change necessitates corresponding updates in child classes to maintain compatibility and prevent potential runtime errors.Changes
This Pull Request introduces the 'void' return type declaration in the
parse()method of theCrEOF\Spatial\ORM\Query\AST\Functions\AbstractSpatialDQLFunctionclass. It ensures compatibility with the anticipated Doctrine updates and enhances code robustness against future changes.