Skip to content

Conversation

@weyert
Copy link

@weyert weyert commented Oct 1, 2018

If you are running SSH on a different port then 22 this command would fail. I have added the optional argument to pass the port it will fallback to 22 when not given

weyert added 2 commits October 1, 2018 19:27
Allow passing a port as second argument so domains were SSH is running on a different port then 22 are supported too
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also document this argument on the usage output?

Looks good though, wondering why this hasn't been reviewed / commented on 😕

@crisward
Copy link
Owner

Looks good though, wondering why this hasn't been reviewed / commented on

Usual reason, not something I need so didn't get round to testing / merging.

To manually test this kind of thing feels like it'd take an age

  • Pull his fork to a live server
  • Setup a git server on a different port
  • try and clone from said git server
  • try and clone with passing a port number for a git server on port 22

I mean I could just blindly merge it but that's bound to break the code in a difficult to predict way. I'm not a bash guru or anything so may have missed something.

Another solution to use a different port is to add something to your ~/.ssh/config file eg

Host git.yourhost.com
    Port 2020

Though I can see why it'd be easier to do this on the cli each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants