change body attribute to a body block for better tooling, fixes #36 #38
+2,141
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the body attribute to a body block for resources and composite status/ connection. It renames the body attribute to a result attribute for functions. This allows for better tooling and schema inference based on the apiVersion and kind attributes of the body block. There is one regression, however. It is now impossible to write a function that returns the entire k8s object since body is a block and no longer an attribute that can be assigned to. In this commit, both old and new forms are accepted and the previous forms are merely deprecated. Signed-off-by: gotwarlost <krishnan.anantheswaran@elastic.co>
Collaborator
Author
|
not needed unless it is for other reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the body attribute to a body block for resources and composite status/ connection. It renames the body attribute to a result attribute for functions. This allows for better tooling and schema inference based on the apiVersion and kind attributes of the body block.
There is one regression, however. It is now impossible to write a function that returns the entire k8s object since body is a block and no longer an attribute that can be assigned to.
In this commit, both old and new forms are accepted and the previous forms are merely deprecated.