docs(config): document admin clean room policy in config example#5
Closed
docs(config): document admin clean room policy in config example#5
Conversation
606ed0f to
214e369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLEAN ROOM POLICYwarning block after the admin sandbox examples inconfig.toml.EXAMPLE, explaining that admin workspaces cannot havepublic_source = trueMCPs (or undeclared MCPs, which default topublic_source = true), that Pynchy refuses to start if violated, and linking to the docsmcp_servers = ["all"]admin sandbox example — using"all"fails validation if any declared server haspublic_source = true, which is the default; replaced with a["caldav"]example and an explanatory comment# pragma: allowlist secretto pre-existing fake CalDAV passwords in the example to unblockdetect-secretsContext
Motivated by today's incident where pynchy-server crash-looped after pulling the admin clean room enforcement commit (
0713e6a), becauseadmin-1andadmin-2both hadplaywright(which haspublic_source = true) in theirmcp_servers. The config example had no indication this was invalid.Test plan
uv run mkdocs build --strictpasses (no broken links)detect-secretspre-commit hook passes