fix: resolve repo_access through sandbox profile merge cascade#6
Merged
fix: resolve repo_access through sandbox profile merge cascade#6
Conversation
Multiple call sites were reading repo_access directly from the raw per-sandbox WorkspaceConfig instead of the three-tier merged config (universal < profile < per-sandbox). This caused sandboxes that inherit repo_access from a sandbox profile (e.g. admin-1 via pynchy-dev) to get repo_access=None, resulting in: - No /workspace/project mount (6 mounts instead of 9) - Container crash: "Working directory does not exist: /workspace/project" - Infinite retry loop on admin-1 Updated all call sites to use load_resolved_config() which correctly resolves repo_access through the merge cascade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo_accessfrom raw per-sandbox config instead of the three-tier merge cascade (sandbox_universal<sandbox_profiles< per-sandbox)repo_accessfrom thepynchy-devprofile) to get no/workspace/projectmount, crashing containers with "Working directory does not exist: /workspace/project"resolve_repo_for_group(),get_repo_access(),get_repo_access_groups(),reconcile_workspaces(),_reconcile_state(), and_write_env_file()to useload_resolved_config()Test plan
curl -s http://pynchy-server:8484/statusshows mount_count restored to 9