You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, specifying an attribute using both its undirected and directed form is "undefined behavior", which in practice manifests as "which ever gets parsed last wins". If we were to define a behavior, my preference would be for the code to just error out, but arguments for other design choices could be made.
The code as-is makes a bit of a sketchy assumption that if the attribute is weightKey + "up" or "down", it's the directed version of that key. This works for the keys we supply, but is not generally safe for all potential keywords (e.g., "c" and "cup"). In practice it's unlikely to be an issue, but it's still a little ugly. One option would to be use camel-case suffixes, which I currently opted not to because of existing bandwidthup/down keys.
The SelfLink direction is arbitrary, I just picked one.
The graphml file is still listed as being an undirected graph, even though this is no longer really true, I think (really, I don't know you could ever say it was, since there was always a notion of "source" and "target" on edges). I don't know the graphml format very well, does undirected mean something else?
status update for posterity: Spoke to Nik, and we agree that it's better to re-do the front-end of this code to use directed graphml instead (plus some other minor fixes). Since the branch as-is works for what I need now, it's not at the top of my priority list, but it will get done eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let me know what you want changed