Selenium rewrite #233
Open
Selenium rewrite #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpha release v0.1.0 (first after split from Screenplay core) This is the first release of the new Screenplay Selenium project since it was split from Screenplay core and moved to its own repo. It mainly does everything that the old used to do. The one exception being the forthcoming browser flags fuctionality. This will replace the old "browser capabilities" (not web driver capabilities) functionality we used to have.
The fix to the crash bug which was blocking me means that now the web browser flags are loading correctly and are visible to the web driver.
Also a rework to Assets and screenshots.
According to https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-9.0#configuration-keys-and-values this is the correct syntax for env vars
Adds the `--no-sandbox` argument to run Chrome as root. See https://developer.chrome.com/docs/chromedriver/help/chrome-doesnt-start for more info
I am confident that it was using the right version, so this change is no longer needed.
Undo this change, I can't do it that way. I must use `AddArgument(string)` instead.
This follows lessons learned in the CSF.Extensions.WebDriver project. * Activate xvfb to provide an X environment for the browser * Ensure we're using the right driver version for the env * Upgrade to latest beta of CSF.Extensions.WebDriver
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for #212 and related issues. It introduces a complete rewrite of the Selenium library, which has been imported (with history) from CSF.Screenplay.Selenium.