Fix: Limit Item Info Injection to Appid 730 #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes injection of SelectedItemInfo so it only runs for appid 730 pages by requiring the .app730 class on the item info containers.
- Updated the
@InjectAfterselectors to include the.app730class on both item info elements.
Comments suppressed due to low confidence (1)
src/lib/components/inventory/selected_item_info.ts:34
- Consider adding unit or integration tests to verify that SelectedItemInfo injection only occurs when the parent has the .app730 class and is skipped otherwise.
@InjectAfter('div.app730#iteminfo0_content .item_desc_description div.item_desc_game_info', InjectionMode.CONTINUOUS)
Step7750
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334 by limiting the injection of
SelectedItemInfoto context DOM parents with theapp730class.