Fix: Handle New Highlight Charms #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of highlight/souvenir charms that were previously displaying empty pattern IDs. The changes exclude highlight charms from being sellable on CSFloat and prevent them from showing pattern information in the UI.
- Introduces
isHighlightCharmfunction to identify highlight charms by checking for 'highlight' tag - Updates CSFloat sellability logic to exclude highlight charms
- Conditionally hides pattern display for highlight charms in the item info component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/utils/skin.ts | Adds isHighlightCharm function and updates isSellableOnCSFloat to exclude highlight charms |
| src/lib/components/inventory/selected_item_info.ts | Imports isHighlightCharm and conditionally renders pattern info for non-highlight charms only |
Step7750
approved these changes
Jul 22, 2025
Step7750
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the extension displays an empty pattern ID for highlight / souvenir charms as they are treated like regular charms.
This PR handles them explicitly as non-sellable on CSFloat and removes the pattern.