-
Notifications
You must be signed in to change notification settings - Fork 36
Adds Rollback Telemetry #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a ping for relevant trades that have been rolled back, along with the ability to fetch trade history via the bridge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds rollback telemetry functionality to track and report trades that have been rolled back through Steam's trade protection system. The changes enable the extension to detect rolled-back trades and send notifications to the CSFloat API.
- Adds new bridge handlers for pinging rollback trades and fetching trade history
- Updates trade history data structures to include rollback-related fields
- Implements rollback detection logic that matches Steam trade history with pending CSFloat trades
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/bridge/handlers/types.ts | Adds new request types for rollback pings and trade history fetching |
| src/lib/bridge/handlers/trade_history_status.ts | Extends interface with rollback and trade tracking fields |
| src/lib/bridge/handlers/ping_rollback_trade.ts | New handler for sending rollback notifications to CSFloat API |
| src/lib/bridge/handlers/handlers.ts | Registers the new bridge handlers |
| src/lib/bridge/handlers/fetch_trade_history.ts | New handler for fetching trade history via bridge |
| src/lib/alarms/trade_history.ts | Updates trade history fetching to support rollback data and parameterized limits |
| src/lib/alarms/rollback.ts | New module implementing rollback detection and notification logic |
| src/lib/alarms/csfloat_trade_pings.ts | Integrates rollback detection into the main trade monitoring flow |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…at/extension into feature/rollback-telemetry
GODrums
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Adds a ping for relevant trades that have been rolled back, along with the ability to fetch trade history via the bridge.