Removal of code duplication for UCTS timing in trr_test_suite#261
Open
pcorcam wants to merge 8 commits intocta-observatory:mainfrom
Open
Removal of code duplication for UCTS timing in trr_test_suite#261pcorcam wants to merge 8 commits intocta-observatory:mainfrom
trr_test_suite#261pcorcam wants to merge 8 commits intocta-observatory:mainfrom
Conversation
…mponent` instead of `UCTSComp`
… the `TriggerTimingTestTool`. Pedestals are also estimated and passed to the `ChargesComponent`.
…nt` instead of `UCTSComp`
… the `DeadtimeTestTool`. Event types are tagged and passed to the `finish` method of the `DeadtimeTestTool`, so that the correct `ChargesContainer` is loaded.
6be2436 to
66a01b2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 51.90% 52.18% +0.28%
==========================================
Files 82 82
Lines 6845 6787 -58
==========================================
- Hits 3553 3542 -11
+ Misses 3292 3245 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up work on PR #244 and PR #260. Removes code duplication in the
trr_test_suiteregarding the UCTS computation. More specifically:Main enhancement
UCTSContainerandUCTSCompare removed fromtrr_test_suite/tools_components.py;ChargesComponent(makers/components/charges_components.py) is now the component in theDeadtimeTestToolandTriggerTimingTestTool(trr_test_suite/tools_components.py);trr_test_suite/deadtime.pyand trr_test_suite/trigger_timing.py have been adapted accordingly. For the latter, pedestals are precomputed with the standardPedestalNectarCAMCalibrationTooland its output is fed to theChargesComponentin theTriggerTimingTestTool.Crosschecks
Crosscheck of
deadtime.pyResults stay exactly the same after changing the component.
Using



UCTSCompUsing



ChargesComponentCrosscheck of
trigger_timing.pyWe see a very small shift in charge (minor changes in computation methods), but overall the results look similar and remain well within the CTAO requirements.
Using

UCTSCompUsing

ChargesComponentConclusion
We are safe to remove the
UCTSCompandUCTSContainerfrom thetrr_test_suite.