Make threshold 128 instead of 127 so that the threshold can cover the whole color range#109
Open
mturnshek wants to merge 1 commit intocubiq:mainfrom
Open
Make threshold 128 instead of 127 so that the threshold can cover the whole color range#109mturnshek wants to merge 1 commit intocubiq:mainfrom
mturnshek wants to merge 1 commit intocubiq:mainfrom
Conversation
… whole color range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this node as part of a workflow and found it would be really nice to have this one number change. If you use 127, values at 255 would be outside the threshold, and if you use 128, values at 0 would be outside the threshold.
127 + 127 = 254
128 - 127 = 1
So this makes it so you can set threshold to 128, which allows full coverage if you want that.