Fix broken KSamplerVariationsStochastic and KSamplerVariationsWithNoise #128
Open
flyingshutter wants to merge 1 commit intocubiq:mainfrom
Open
Fix broken KSamplerVariationsStochastic and KSamplerVariationsWithNoise #128flyingshutter wants to merge 1 commit intocubiq:mainfrom
flyingshutter wants to merge 1 commit intocubiq:mainfrom
Conversation
fixing the Samplers
flyingshutter
changed the title
|
Thanks for the fix. Did see that too late. I updated a fork with the new ComfyUI typing (https://github.com/comfyanonymous/ComfyUI/tree/master/comfy/comfy_types). However, there are a lot of nodes I don't use, so I'm note able to test whether all the adaptions work properly and hence not condident to post a PR. If anyone is interested: https://github.com/stdkoehler/ComfyUI_essentials |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing the Samplers
KSamplerVariationsStochastic and KSamplerVariationsWithNoise (which I use excessively ;-) ) stopped working days ago.
This pull request fixes them.
I don't know the root cause, I just updated the broken noise seeds to reflect the changes in main comfyui's KSampler node.
If I had to guess I would say INT:seed isn't a thing anymore.