(WIP) [Monitor] Fix failing round-trip tests related to combinational adders#197
Draft
(WIP) [Monitor] Fix failing round-trip tests related to combinational adders#197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(WIP) Bunch of bug-fixes related to failing round-trip tests for combinational adders that are triggered on the monitor side
elsebranch ofif { ... } else { }, proceed to the next statement instead of terminating the thread (this was a bug in the old implementation)fork()instead ofstep()as their final statement^^ this is an ad-hoc fix for now until we figure out how to deal with ill-formed protocols in the monitor (see the two possible solutions discussed in Slack)