[CUP-10] Pass down the tag to the story service.#191
Open
cupcicm wants to merge 3 commits intocupcicm/pr/190from
Open
[CUP-10] Pass down the tag to the story service.#191cupcicm wants to merge 3 commits intocupcicm/pr/190from
cupcicm wants to merge 3 commits intocupcicm/pr/190from
Conversation
The state was managed by the LocalPR itself. Create a class to handle it outside the PR so that we can store state for branches too.
This tag can be modified with "opp branch tag XXX" and it can be used to tag a local branch with a story. All PRs created from this local branch will have the story.
Consider the tag as an input when choosing what story a PR is linked to. If the tag contains the regex with brackets, or if it's exactly the regex without the brackets, then link the PR to that story.
ClairePhi
reviewed
Oct 20, 2024
| return story, strings.Join([]string{s.formatStoryInPRTitle(story), rawTitle}, " ") | ||
| } | ||
|
|
||
| if branchTag != "" { |
Collaborator
There was a problem hiding this comment.
The method findStory is dedicated to finding the Story (other than having it in the rawTitle). Today we have extractCommitFromMessages, and we are currently implementing fetchStory. Could we add there "finding the Story from the branch tag"? (I think before fetchStory?)
cupcicm
force-pushed
the
cupcicm/pr/190
branch
from
0f52b94 to
0a4f92f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the tag as an input when choosing what
story a PR is linked to. If the tag contains the
regex with brackets, or if it's exactly the regex
without the brackets, then link the PR to that story.