Finally: make all production code not depend on go-git.#234
Merged
Conversation
And remove the `git.Repository` dependency in `Repo`. I needed to refacto a bit the `head_test` were a lot of the tests were checking the compatibility with go-git.
ClairePhi
approved these changes
Feb 8, 2026
core/repo.go
Outdated
| type Repo struct { | ||
| *git.Repository | ||
| s *StateStore | ||
| path string |
Collaborator
There was a problem hiding this comment.
Suggested change
| path string | |
| rootPath string |
cupcicm
force-pushed
the
cupcicm/pr/234
branch
from
ff87e05 to
5352394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove the
git.Repositorydependency inRepo.I needed to refacto a bit the
head_testwere a lot of the testswere checking the compatibility with go-git.