Skip to content

Conversation

@denessapi
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (9b8c3dd) to head (c2b4ee3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          16       16           
  Lines         749      749           
  Branches      135      133    -2     
=======================================
  Hits          726      726           
  Misses         22       22           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@denessapi denessapi requested review from Copilot and gbence June 19, 2025 10:01

This comment was marked as outdated.

@denessapi denessapi force-pushed the denes-typing-fixes branch from 5c7724f to c2b4ee3 Compare June 19, 2025 10:38
@denessapi denessapi requested a review from Copilot June 19, 2025 10:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request focuses on fixing JSDoc typings and aligning transport class constructor signatures across the codebase.

  • Corrected JSDoc type annotations by replacing int/bool with number/boolean and more precise function signature annotations.
  • Removed the allowInMemoryBuffer parameter from HTTP, WS, and Dummy transport constructors.
  • Updated version numbers in constants and package.json.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/trap.js Updated JSDoc annotations and modified the HTTP transport instantiation to remove the buffer parameter.
src/transport/ws.js Removed the allowInMemoryBuffer parameter from the constructor for consistency.
src/transport/http.js Eliminated the allowInMemoryBuffer parameter in the HTTP transport constructor.
src/transport/dummy.js Simplified the Dummy transport constructor by removing the allowInMemoryBuffer parameter.
src/constants.js Bumped package version from 1.0.21 to 1.0.22.
package.json Updated version number to match constants.
Comments suppressed due to low confidence (4)

src/trap.js:72

  • The removal of the buffer parameter in the HTTP constructor call should be double-checked to ensure it aligns with the intended behavior across the codebase.
      transport: new HTTP(this._metadata),

src/transport/ws.js:13

  • Removing the allowInMemoryBuffer parameter aligns with updates across transport classes; ensure that all invocations of this constructor are updated accordingly.
  constructor(metadata, logger) {

src/transport/http.js:15

  • The removal of the allowInMemoryBuffer parameter simplifies the constructor; ensure that all consumers of the HTTP class are updated to match the new signature.
  constructor(metadata) {

src/transport/dummy.js:13

  • Removing the allowInMemoryBuffer parameter in Dummy is consistent with other transport classes; verify that this change does not affect the buffering behavior where it is used.
  constructor(metadata) {

@denessapi denessapi merged commit 44d6df3 into main Jun 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants