fix: prevent crash when result of SendMessage is 0 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssh 8.9 introduces feature "SSH agent restriction", which means protocol extension (SSH_AGENTC_EXTENSION) will be used (https://www.openssh.com/agent-restrict.html#limitations). When connecting to older pageant with openssh 8.9 client, the message with type SSH_AGENTC_EXTENSION can't be processed by pageant, thus SendMessage returns 0, in which case `psd` and `usersid` is likely to be freed twice in the code, causing crash. This commit fixes this.
cuviper
reviewed
Apr 27, 2022
Owner
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
Thanks, that was a clear oversight. 😬
While we're here (or perhaps another PR), do you want to increase AGENT_MAX_MSGLEN? Putty has been using 256kB for a while now:
https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=98528db25a9df211141b8711a3756ee2b6ea26e9
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openssh 8.9 introduces feature "SSH agent restriction", which
means protocol extension (SSH_AGENTC_EXTENSION) will be used
(https://www.openssh.com/agent-restrict.html#limitations).
When connecting to older pageant with openssh 8.9 client,
the message with type SSH_AGENTC_EXTENSION can't be processed
by pageant, thus SendMessage returns 0, in which case
psdandusersidis likely to be freed twice in the code,causing crash.
This commit fixes this.