General fixes + get it working on OSX#4
Open
MatsWillemsen wants to merge 5 commits intocvangysel:masterfrom
Open
General fixes + get it working on OSX#4MatsWillemsen wants to merge 5 commits intocvangysel:masterfrom
MatsWillemsen wants to merge 5 commits intocvangysel:masterfrom
Conversation
Owner
|
Thanks for your contributions. To keep things organised, can you please:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling Index() failed, because Indri reports an error, do not PY_DECREF self->query_env_obj, because it is likely NULL (it gets created later), so use the safe PY_XDECREF.
Also, with clang (on OSX), it needs to be specified that the code is C++11, to understand some of the features in the code. On Ubuntu, it works out of the box.