Skip to content

General fixes + get it working on OSX#4

Open
MatsWillemsen wants to merge 5 commits intocvangysel:masterfrom
MatsWillemsen:master
Open

General fixes + get it working on OSX#4
MatsWillemsen wants to merge 5 commits intocvangysel:masterfrom
MatsWillemsen:master

Conversation

@MatsWillemsen
Copy link

When calling Index() failed, because Indri reports an error, do not PY_DECREF self->query_env_obj, because it is likely NULL (it gets created later), so use the safe PY_XDECREF.

Also, with clang (on OSX), it needs to be specified that the code is C++11, to understand some of the features in the code. On Ubuntu, it works out of the box.

@cvangysel
Copy link
Owner

Thanks for your contributions. To keep things organised, can you please:

  1. Split up this issue in two separate issues (one for the installation fix, another for the reference counting fix).
  2. Remove any unnecessary commits/changes from the pull requests (e.g., adding a Homebrew file and removing it directly afterwards is just noise, the comment you add at the top of setup.py has to go, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants