Fix: Handle the zip file extraction - in a way that allows to handle#882
Merged
FH-Inway merged 3 commits intod365collaborative:masterfrom Mar 30, 2025
Merged
Fix: Handle the zip file extraction - in a way that allows to handle#882FH-Inway merged 3 commits intod365collaborative:masterfrom
FH-Inway merged 3 commits intod365collaborative:masterfrom
Conversation
No initial folder Folder - but empty Folder - with files, being wiped - prior moving forward If the folder exists - user will be asked to use force, regardless of the folder containing files or not
Collaborator
Author
|
Please review - and test locally, to ensure I didn't miss anything. |
And updated unit tests
FH-Inway
approved these changes
Mar 24, 2025
Member
FH-Inway
left a comment
FH-Inway
left a comment
There was a problem hiding this comment.
Code looks good to me. I see on Yammer you already tested the UDE version. Since it is the same logic change for the non-UDE version, we could risk it.
I could do a local test on my side next Sunday.
Collaborator
Author
|
I'll prefer to wait for your testing, before we ship it. |
Member
|
Tested successfully and shippend. I posted a notice about the new version at https://www.yammer.com/dynamicsaxfeedbackprograms/#/Threads/show?threadId=3079391106359296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No initial folder
Folder - but empty
Folder - with files, being wiped - prior moving forward
If the folder exists - user will be asked to use force, regardless of the folder containing files or not