-
Notifications
You must be signed in to change notification settings - Fork 0
Type checking (Closes #18) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add binary and unary expressions add variable references
…ation) and (range -> int), validate agent instance
…ix type name for enums
…checks to comparison operator
…r due to false positive of code secrets check
* It is nicer not to require devs to install/update vsce globally * --allow-package-secret is only available on vsce >= 3.4.0
Typir 0.2.2 brings in Langium 3.5.0 which for some reason breaks everything. Stay with 0.2.1 for now
I did it! As it turns out, if you peek the .ref field of a Reference<> object that does not link, Langium gets really mad. We use an inference rule to make type inference of these nodes "lazy", and lookup if a custom type (ie., an Enum) exists that matches the ref's .$refText field (which is always available).
It was doing nothing (no rules) and version 8 is EOL anyway.
* Langium 3.5.0 * Typir 0.2.2 * Concurrently 9.2.0 * Typescript 5.5.0
Updated chalk, monaco-languageclient, types/node, typescript, vite, vitest. Removed vscode (monaco-vscode-api).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @tonitrus888 for getting this project off the ground.
I expect this to create a few conflict with the
masterbranch because a few dependencies have been updated along the way. Let's see.