Measure font descenders #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that Font::PreparedFontString::getUsedAreaSize() returns an accurate value without changing glyph positions or line heights, track descenders using the delta between the glyph's height and its horiBearingY metric. See https://freetype.org/freetype2/docs/tutorial/step2.html for context on the unreliability of descender metrics.
Owner
|
yeah, I know from first hand experience that the metrics from freetype aren't perfect. So I was more thinking along the lines that that 25% you added in the other pull request belongs here to account for "EE" case. I'm not sure what I think about the height of a prepared text bit being depended on the type of glyph used. As when things are fully scrolling down, like logs, they suddenly can jump if a descender glyph is added to the last line. (not sure what is better, I'll have to look at the details of the pull request) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that
Font::PreparedFontString::getUsedAreaSize()returns an accurate value without changing glyph positions or line heights, track descenders using the delta between the glyph'sheightand itshoriBearingYmetric.See https://freetype.org/freetype2/docs/tutorial/step2.html for context on the unreliability of descender metrics.